Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[serverless-1.31] patch func deploy task for serverless 1.31.1 #743

Closed
wants to merge 1 commit into from
Closed

[serverless-1.31] patch func deploy task for serverless 1.31.1 #743

wants to merge 1 commit into from

Conversation

jrangelramos
Copy link

patch for func-deploy task to use midstream specific client built for 1.31.1

@openshift-ci openshift-ci bot requested review from gauron99 and vyasgun February 8, 2024 13:47
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jrangelramos

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Feb 8, 2024
@jrangelramos jrangelramos mentioned this pull request Feb 8, 2024
Closed
@jrangelramos jrangelramos requested review from matejvasek and removed request for gauron99 and vyasgun February 8, 2024 13:49
@jrangelramos
Copy link
Author

it should be on hold until new image is published.

@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (serverless-1.31@7cd8e19). Click here to learn what that means.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@                Coverage Diff                 @@
##             serverless-1.31     #743   +/-   ##
==================================================
  Coverage                   ?   35.35%           
==================================================
  Files                      ?      107           
  Lines                      ?    14535           
  Branches                   ?        0           
==================================================
  Hits                       ?     5139           
  Misses                     ?     8717           
  Partials                   ?      679
Flag Coverage Δ
e2e-test 36.47% <0.00%> (?)
e2e-test-runtime-go 25.13% <0.00%> (?)
e2e-test-runtime-node 26.92% <0.00%> (?)
e2e-test-runtime-python 26.92% <0.00%> (?)
e2e-test-runtime-quarkus 27.03% <0.00%> (?)
e2e-test-runtime-rust 25.92% <0.00%> (?)
e2e-test-runtime-springboot 26.06% <0.00%> (?)
e2e-test-runtime-typescript 27.03% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jrangelramos
Copy link
Author

duplicated by #759

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matejvasek matejvasek Awaiting requested review from matejvasek

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrangelramos @codecov-commenter